This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Minor ELF32/ia64 cleanup
- From: James E Wilson <wilson at specifixinc dot com>
- To: Steve Ellcey <sje at cup dot hp dot com>
- Cc: "H. J. Lu" <hjl at lucon dot org>, binutils at sources dot redhat dot com
- Date: Wed, 04 May 2005 16:04:18 -0700
- Subject: Re: PATCH: Minor ELF32/ia64 cleanup
- References: <200505042142.OAA16114@hpsje.cup.hp.com>
On Wed, 2005-05-04 at 14:42, Steve Ellcey wrote:
> Well, that patch got me farther. Now I die when compiling
> bfd/elflink.c. HP-UX does have the ffs function, it's definition is in
> <strings.h> which elflink.c apparently doesn't include. If I include
> strings.h in elflink.c then I can build it
Most of these problems you are running into are due to -Werror. It was
a relatively recent change to enable it by default when using gcc to
compile binutils. Apparently no one has tested mainline on hpux since
that change. These should all be fixable with trivial changes.
You can disable this by using the configure option --disable-werror.
For the redefined MIN macro, it is better to add #undef than to add
#ifndef. We want to make sure we get the right definition of MIN, which
is our definition, not the one from the system header files. The one in
the system header files could do anything, and there is no guarantee
that it returns the minimum of two numbers. GCC uses a #undef here, and
it hasn't been a problem for gcc.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com