Re: Another HP-UX IA64 Build patch

[Daniel Jacobowitz <drow at false dot org>]

On Thu, May 05, 2005 at 11:10:30AM -0700, James E Wilson wrote:
> On Thu, 2005-05-05 at 10:51, Steve Ellcey wrote:
> > I see it doesn't have the const modifier that libiberty has.  I didn't
> > get a warning or error presumbably because the build didn't include
> > libgen.h.
> 
> This is a libiberty bug.  Try "man basename" on a linux system, and it
> will tell you that there are two versions of basename.  The posix one
> which takes a char * argument, and a glibc _GNU_SOURCE one which takes a
> const char * argument.  So this probably should be something like
> #if defined(_GNU_SOURCE)
> extern char *basename (const char *);
> #elif defined...
> extern char *basename (char *);
> #else
> extern char *basename ();
> #endif
> 
> But it appears that nobody is including libgen.h anywhere, or we would
> have caught this before.

Wait, huh?  What do glibc's quirks have to do with HP/UX's libgen.h?

If you use <libgen.h> on a glibc system you're going to get it without
the const, no matter what _GNU_SOURCE says.

-- 
Daniel Jacobowitz
CodeSourcery, LLC