This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
PATCH: PR 843: objdump prints wrong register size for "jmpq/callq *%XXX"
- From: "H. J. Lu" <hjl at lucon dot org>
- To: binutils at sources dot redhat dot com
- Date: Fri, 6 May 2005 12:59:01 -0700
- Subject: PATCH: PR 843: objdump prints wrong register size for "jmpq/callq *%XXX"
Indirct call/jmp is special in x86_64. This patch fixes the
disassembler.
H.J.
----
gas/testsuite/
2005-05-06 H.J. Lu <hongjiu.lu@intel.com>
PR 843
* gas/i386/i386.exp: Add x86-64-branch.
* gas/i386/x86-64-branch.d: New.
* gas/i386/x86-64-branch.s: New.
opcodes/
2005-05-06 H.J. Lu <hongjiu.lu@intel.com>
PR 843
* i386-dis.c (branch_v_mode): New.
(indirEv): Use branch_v_mode instead of v_mode.
(OP_E): Handle branch_v_mode.
--- binutils/gas/testsuite/gas/i386/i386.exp.br 2005-05-05 09:15:43.000000000 -0700
+++ binutils/gas/testsuite/gas/i386/i386.exp 2005-05-06 12:42:30.000000000 -0700
@@ -127,6 +127,7 @@ if [expr ([istarget "i*86-*-*"] || [ista
run_list_test "x86-64-inval" "-al"
run_list_test "x86-64-segment" "-al"
run_list_test "x86-64-inval-seg" "-al"
+ run_dump_test "x86-64-branch"
# For ELF targets verify that @unwind works.
if { ([istarget "*-*-elf*"] || [istarget "*-*-linux*"]
--- binutils/gas/testsuite/gas/i386/x86-64-branch.d.br 2005-05-06 12:41:50.000000000 -0700
+++ binutils/gas/testsuite/gas/i386/x86-64-branch.d 2005-05-06 12:51:24.000000000 -0700
@@ -0,0 +1,13 @@
+#as: -J
+#objdump: -drw
+#name: x86-64 indirect branch
+
+.*: +file format elf64-x86-64
+
+Disassembly of section .text:
+
+0+000 <.text>:
+[ ]*0:[ ]+ff d0[ ]+callq[ ]+\*%rax
+[ ]*2:[ ]+ff d0[ ]+callq[ ]+\*%rax
+[ ]*4:[ ]+ff e0[ ]+jmpq[ ]+\*%rax
+[ ]*6:[ ]+ff e0[ ]+jmpq[ ]+\*%rax
--- binutils/gas/testsuite/gas/i386/x86-64-branch.s.br 2005-05-06 12:41:48.000000000 -0700
+++ binutils/gas/testsuite/gas/i386/x86-64-branch.s 2005-05-06 12:52:12.000000000 -0700
@@ -0,0 +1,5 @@
+.text
+ callq *%rax
+ call *%rax
+ jmpq *%rax
+ jmp *%rax
--- binutils/opcodes/i386-dis.c.br 2005-05-05 12:26:27.000000000 -0700
+++ binutils/opcodes/i386-dis.c 2005-05-06 12:38:48.000000000 -0700
@@ -197,7 +197,7 @@ fetch_data (struct disassemble_info *inf
#define Eq OP_E, q_mode
#define Edq OP_E, dq_mode
#define Edqw OP_E, dqw_mode
-#define indirEv OP_indirE, v_mode
+#define indirEv OP_indirE, branch_v_mode
#define indirEp OP_indirE, f_mode
#define Ew OP_E, w_mode
#define Ma OP_E, v_mode
@@ -323,6 +323,7 @@ fetch_data (struct disassemble_info *inf
#define dqw_mode 12 /* registers like dq_mode, memory like w_mode. */
#define f_mode 13 /* 4- or 6-byte pointer operand */
#define const_1_mode 14
+#define branch_v_mode 15 /* v_mode for branch. */
#define es_reg 100
#define cs_reg 101
@@ -3155,6 +3156,18 @@ OP_E (int bytemode, int sizeflag)
else
oappend (names32[rm + add]);
break;
+ case branch_v_mode:
+ if (mode_64bit)
+ oappend (names64[rm + add]);
+ else
+ {
+ if ((sizeflag & DFLAG) || bytemode != branch_v_mode)
+ oappend (names32[rm + add]);
+ else
+ oappend (names16[rm + add]);
+ used_prefixes |= (prefixes & PREFIX_DATA);
+ }
+ break;
case v_mode:
case dq_mode:
case dqw_mode:
@@ -3254,6 +3267,7 @@ OP_E (int bytemode, int sizeflag)
case dqw_mode:
oappend ("WORD PTR ");
break;
+ case branch_v_mode:
case v_mode:
case dq_mode:
USED_REX (REX_MODE64);