This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
PATCH: PR 992: regression: ld selective1 and selective2 fails, cris-elf
- From: "H. J. Lu" <hjl at lucon dot org>
- To: binutils at sources dot redhat dot com
- Date: Fri, 3 Jun 2005 23:35:51 -0700
- Subject: PATCH: PR 992: regression: ld selective1 and selective2 fails, cris-elf
The updated patch of
http://sourceware.org/ml/binutils/2005-06/msg00030.html
should also fix PR 992.
H.J.
---
2005-06-03 H.J. Lu <hongjiu.lu@intel.com>
PR 992
* ldexp.c (exp_mark_used_section): Set SEC_KEEP on current
section for etree_assign, etree_provide and etree_provided.
Call fold_binary on etree_binary.
* ldlang.c (lang_mark_used_section_1): Handle load base.
--- ld/ldexp.c.base 2005-06-02 16:02:26.000000000 -0700
+++ ld/ldexp.c 2005-06-03 23:16:33.000000000 -0700
@@ -1217,6 +1217,8 @@ align_n (bfd_vma value, bfd_vma align)
void
exp_mark_used_section (etree_type *tree, asection *current_section)
{
+ bfd_vma dot = 0;
+
switch (tree->type.node_class)
{
case etree_value:
@@ -1232,6 +1234,8 @@ exp_mark_used_section (etree_type *tree,
break;
case etree_binary:
+ fold_binary (tree, current_section, lang_allocating_phase_enum,
+ dot, &dot, TRUE);
break;
case etree_trinary:
@@ -1243,12 +1247,12 @@ exp_mark_used_section (etree_type *tree,
if (tree->assign.dst[0] != '.' || tree->assign.dst[1] != 0)
{
etree_value_type result;
- bfd_vma dot = 0;
result = exp_fold_tree_1 (tree->assign.src,
current_section,
lang_allocating_phase_enum,
dot, &dot, TRUE);
+ current_section->flags |= SEC_KEEP;
if (result.valid_p)
{
bfd_boolean create;
--- ld/ldlang.c.base 2005-06-03 22:28:20.000000000 -0700
+++ ld/ldlang.c 2005-06-03 22:54:05.000000000 -0700
@@ -3065,7 +3065,12 @@ lang_mark_used_section_1
os = &(s->output_section_statement);
if (os->bfd_section != NULL)
- lang_mark_used_section_1 (os->children.head, os);
+ {
+ lang_mark_used_section_1 (os->children.head, os);
+ if (os->load_base)
+ exp_mark_used_section (os->load_base,
+ bfd_abs_section_ptr);
+ }
}
break;
case lang_wild_statement_enum: