This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Your binutils patch today caused a "fatal warning"

Jakub Jelinek <jakub@redhat.com> writes:

> Works for me just fine.
>         if (hdr->sh_entsize != (hdr->sh_type == SHT_REL
>                                 ? bed->s->sizeof_rel : bed->s->sizeof_rela))
>           return FALSE;
>
> Now, sizeof_rel and sizeof_rela are unsigned char, hdr->sh_entsize
> is bfd_size_type, which ought to be unsigned type.

unsigned char gets promoted to int, thus the warning is correct.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]