This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PPC small data symbols.


On Wed, Jun 29, 2005 at 02:22:40AM +0100, Paul Brook wrote:
> 	* elf32-ppc.c (ppc_elf_set_sdata_syms): Make sdata symbols section
> 	relative.

This slipped past my review.

	* elf32-ppc.c (ppc_elf_set_sdata_syms): Correct __sbss_start value.

Index: bfd/elf32-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-ppc.c,v
retrieving revision 1.171
diff -u -p -r1.171 elf32-ppc.c
--- bfd/elf32-ppc.c	8 Jul 2005 06:19:59 -0000	1.171
+++ bfd/elf32-ppc.c	12 Jul 2005 09:40:43 -0000
@@ -5307,12 +5311,11 @@ ppc_elf_set_sdata_syms (bfd *obfd, struc
     }
 
   s = bfd_get_section_by_name (obfd, ".sbss");
-  _bfd_elf_provide_symbol (info, "__sbss_start", 0, NULL);
-  _bfd_elf_provide_symbol (info, "___sbss_start", 0, NULL);
+  val = 0;
+  _bfd_elf_provide_symbol (info, "__sbss_start", val, s);
+  _bfd_elf_provide_symbol (info, "___sbss_start", val, s);
   if (s != NULL)
     val = s->size;
-  else
-    val = 0;
   _bfd_elf_provide_symbol (info, "__sbss_end", val, s);
   _bfd_elf_provide_symbol (info, "___sbss_end", val, s);
   return TRUE;

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]