This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ia64: equate improvements
- From: James E Wilson <wilson at specifix dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 11 Oct 2005 11:14:39 -0700
- Subject: Re: [PATCH] ia64: equate improvements
- References: <433D7B25.76F0.0078.0@novell.com>
On Fri, 2005-09-30 at 08:51, Jan Beulich wrote:
> * config/tc-ia64.c (dot_reg_val): Use expression_and_evaluate.
> (dot_pred_rel): Likewise.
> (parse_operand): Likewise.
> (ia64_unrecognized_line): Likewise.
> (md_operand): Likewise.
> * gas/ia64/forward.[sd]: New.
> * gas/ia64/ia64.exp: Run new test.
OK.
You changed all expression calls in tc-ia64.c to expression_and_evaluate
except for one. This missed one is in ia64_parse_name, and is used for
expressions inside link operators such as @gprel(expr). Is there a
reason why you left this one alone? It looks to me like it should have
been converted also in order to be consistent. OK if you change that
one too.
By the way, your previous ChangeLog entry has some typos. "thrid"
instead of "third" occurs twice.
--
Jim Wilson, GNU Tools Support, http://www.specifix.com