This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] linker regression fix


>>> "H. J. Lu" <hjl@lucon.org> 21.10.05 16:47:15 >>>
>On Fri, Oct 21, 2005 at 04:19:51PM +0200, Jan Beulich wrote:
>> The patch in http://sourceware.org/ml/binutils/2005-04/msg00325.html

>> causes
>> local absolute symbols, including .file ones, to be removed from
the
>> linker
>> output. This patch tries to adjust this.
>> 
>> +++ 2005-10-20/bfd/elflink.c	2005-10-20 16:59:37.552695912
+0200
>> @@ -6871,8 +6871,9 @@ elf_link_input_bfd (struct elf_final_lin
>>  	continue;
>>  
>>        /* If the section is not in the output BFD's section list, it
is
>> not
>> -	 being output.  */
>> -      if (bfd_section_removed_from_list (output_bfd,
>> isec->output_section))
>> +	 being output. But don't consider the *ABS* section here.  */
>> +      if (bfd_section_removed_from_list (output_bfd,
>> isec->output_section)
>> +	  && !bfd_is_abs_section (isec->output_section))
>>  	continue;
>>  
>
>Shouldn't bfd_section_removed_from_list be modified to handle the ABS
>section?

I don't know if that's safe/correct.

Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]