This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: ld/1487: ELF input section may not be handled properly
On Mon, Oct 24, 2005 at 10:44:55AM +0930, Alan Modra wrote:
> On Sun, Oct 16, 2005 at 07:55:15PM -0700, H. J. Lu wrote:
> > 2005-10-16 H.J. Lu <hongjiu.lu@intel.com>
> >
> > PR ld/1487
> > * elf.c (elf_fake_sections): Don't set SHF_GROUP for
> > relocatable link.
> > (bfd_elf_set_group_contents): Don't handle relocatable link
> > specially.
> > (_bfd_elf_init_private_section_data): New.
> > (_bfd_elf_copy_private_section_data): Call it.
> >
> > * libbfd-in.h (_bfd_generic_init_private_section_data): New.
> >
> > * libbfd.c (_bfd_generic_init_private_section_data): New.
> >
> > * targets.c (BFD_JUMP_TABLE_COPY): Add
> > _bfd_generic_init_private_section_data.
> > (bfd_init_private_section_data): Likewise.
> >
> > * bfd-in2.h: Regenerated.
> > * libbfd.h: Likewise.
> >
> > ld/
> >
> > 2005-10-16 H.J. Lu <hongjiu.lu@intel.com>
> >
> > PR ld/1487
> > * emultempl/elf32.em (gld${EMULATION_NAME}_place_orphan): Call
> > bfd_match_sections_by_type to match section types.
> >
> > * ldlang.c (init_os): Take the input section. Call
> > bfd_init_private_section_data if the input section isn't NULL.
> > (exp_init_os): Pass NULL to init_os.
> > (map_input_to_output_sections): Likewise.
> > (lang_add_section): Pass the input section to init_os.
>
> This is OK if you have tested gas, ld, ld -r, and objcopy with input
> containing sections groups, preferably with groups that have more that
> one section.
Yes, I have. I will check it in.
H.J.