This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: allow equates to registers
- From: "Jan Beulich" <JBeulich at novell dot com>
- To: "Nick Clifton" <nickc at redhat dot com>
- Cc: <binutils at sourceware dot org>
- Date: Wed, 26 Oct 2005 14:38:42 +0200
- Subject: Re: [PATCH] x86: allow equates to registers
- References: <43592D6E.76F0.0078.0@novell.com> <435F56A2.1000200@redhat.com>
Nick,
I already applied it when I remembered the dependency noted in the
submission email. How about that patch
(http://sourceware.org/ml/binutils/2005-10/msg00297.html), without
which the newly added test is expected to fail.
Jan
>>> Nick Clifton <nickc@redhat.com> 26.10.05 12:12:50 >>>
Hi Jan,
> This patch allows, on x86/x86-64, registers to be on the right side
of
> .equ and similar operations, and (obviously) also allows the
resulting
> symbols to be used.
I have not seen any adverse comments to this patch, so:
> gas/
> 2005-10-21 Jan Beulich <jbeulich@novell.com>
>
> * config/tc-i386.c (i386_operand): Don't check register prefix
> here.
> (parse_real_register): Rename from parse_register.
> (parse_register): New.
> (i386_parse_name): New.
> (md_operand): New.
> (intel_e11): Don't tolerate registers in offset expressions
> anymore.
> (intel_get_token): Don't check register prefix here. Copy the
> actual
> register token, not the canonical register name.
> * config/tc-i386.h (md_operand): Delete.
> (i386_parse_name): Declare.
> (md_parse_name): Define.
>
> gas/testsuite/
> 2005-10-21 Jan Beulich <jbeulich@novell.com>
>
> * gas/i386/intel.s: Replace register used in offset expression.
> * gas/i386/intel.e: Adjust.
> * gas/i386/intelbad.l: Adjust.
> * gas/i386/equ.[sed]: New.
> * gas/i386/i386.exp: Run new test.
Approved - please apply.
Cheers
Nick