This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: ld/1567: 64-bit vma overflow signalled from 32-bit-target address-wrap
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 28 Oct 2005 10:10:08 -0700
- Subject: Re: PATCH: ld/1567: 64-bit vma overflow signalled from 32-bit-target address-wrap
- References: <20051028163715.GA15488@lucon.org> <200510281701.j9SH1Lnk016863@ignucius.se.axis.com>
On Fri, Oct 28, 2005 at 07:01:21PM +0200, Hans-Peter Nilsson wrote:
> > Date: Fri, 28 Oct 2005 09:37:15 -0700
> > From: "H. J. Lu" <hjl@lucon.org>
>
> > I don't think
> >
> > http://sourceware.org/ml/binutils/2005-10/msg00427.html
> >
> > is correct. complain_overflow_bitfield will fail for all 32bit targets
> > with 32bit RELA relocations when 64bit bfd_vma is used.
>
> Well, I *did* indicate that something in the direction you're
> heading was better (thanks for looking into it)...
>
> > _bfd_relocate_contents has support for 32bit REL relocations, but not
> > RELA relocations. This patch should work.
>
> ... but it's not really *wrong* to disable overflow-checking on
> that reloc in elf32-cris.c because there *can be* no overflow
> for 32-bit arithmetic in 32-bit ELF. (Note that "32-bit" is the
> GCC spelling convention, so we'd better use that.)
>
> So, I'd rather keep the elf32-cris.c bits, don't apply that
> part, please.
I will leave it to you.
H.J.