This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Patch](gas/testsuite): fix cofftag test for target z80 / numbers withsuffix


Hello

The cofftag test in gas/testsuite/gas/all currently fails on 
z80-unknown-coff because z80 has NUMBERS_WITH_SUFFIX and does 
not recognise the prefix 0 for octal numbers. 
The patch below fixes this by converting the numbers in 
the .type directives to decimal.
I think such a change is acceptable here, if not I'll have to 
add the modified testcase to the z80 directory.

Kind regards,
Arnold

* gas/all/cofftag.s: convert numbers in .type 
directives to decimal
* gas/all/gas.exp: enable cofftag-test for z80-*-coff
Index: gas/all/cofftag.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/cofftag.s,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 cofftag.s
--- gas/all/cofftag.s	3 May 1999 07:28:47 -0000	1.1.1.1
+++ gas/all/cofftag.s	4 Nov 2005 19:17:45 -0000
@@ -6,6 +6,9 @@
 	};
 	 
 	enum token what= operator;
+
+   Type numbers have been converted to decimal to make this test pass on
+   ports having NUMBERS_WITH_SUFFIX.
  */
 
 	.file	"foo.c"
@@ -18,18 +21,18 @@
 .text
 	.def	_token
 	.scl	15
-	.type	012
+	.type	10
 	.size	4
 	.endef
 	.def	_operator
 	.val	0
 	.scl	16
-	.type	013
+	.type	11
 	.endef
 	.def	_flags
 	.val	1
 	.scl	16
-	.type	013
+	.type	11
 	.endef
 	.def	.eos
 	.val	4
@@ -46,12 +49,12 @@
 	.def	_token
 	.val	_token
 	.scl	2
-	.type	02
+	.type	2
 	.endef
 	.def	_what
 	.val	_what
 	.scl	2
 	.tag	_token
 	.size	4
-	.type	012
+	.type	10
 	.endef
Index: gas/all/gas.exp
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/gas.exp,v
retrieving revision 1.35
diff -u -r1.35 gas.exp
--- gas/all/gas.exp	4 Nov 2005 13:25:59 -0000	1.35
+++ gas/all/gas.exp	4 Nov 2005 19:17:46 -0000
@@ -189,8 +189,7 @@
 # We omit the ARM toolchains because they define locals to
 #  start with '.', which eliminates .eos, .text etc from the output.
 # Omit c54x, since .tag and .def mean something different on that target
-# Omit Z80, since octal numbers need a suffix on that target
-if {   ([istarget *-*-coff*] && ![istarget *arm*-*-coff] && ![istarget thumb*-*-coff] && ![istarget xscale-*-coff] && ![istarget *c4x*-*-coff] && ![istarget *c54x*-*-coff] && ![istarget z80-*-coff]) \
+if {   ([istarget *-*-coff*] && ![istarget *arm*-*-coff] && ![istarget thumb*-*-coff] && ![istarget xscale-*-coff] && ![istarget *c4x*-*-coff] && ![istarget *c54x*-*-coff]) \
      ||([istarget *-*-pe*] && ![istarget arm*-*-pe*] && ![istarget thumb*-*-pe*]) \
      || [istarget i*86-*-aix*] \
      || [istarget i*86-*-sco*] \

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]