This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: Your gas changes caused weakref failures forcris-elf, supposedly others too

>Same here.  If S_IS_COMMON doesn't work, we need to fix it.  I'll be
>happy to review a followup patch.

So for a quick solution I'd prefer changing S_IS_COMMON then in the way
you outlined in the response to the '.comm symbol, 0' question - is that
OK for you? I don't think I feel certain to fix the other object formats
to properly set the section on common symbols (my main fear is they may
have hidden dependencies on that).

Also this means I'll hold back applying this patch to avoid introducing
testsuite failures.

Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]