This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fix weakref tests for alpha


I was actually thinking of a different approach to address the .equ/.set
issue in gas/testsuite/gas/all generally: Since all targets, as far as I
was able to figure out, support at least one of generic .set or generic
.equ, why not abstract this out and create an include file which defines
a macro, expanding to either .set or .equ depending on the target. Short
of a gas option to force inclusion of a file from the command line, a
command line option indicating the desired selection would then need to
be passed (perhaps globally, so that other non-target-specific tests
could also benefit).

Also, I got just now aware of Richards change to the test, my checkin
earlier today (but after Richard's) actually disabled the test for all
the targets that are known to implement .set differently (the same
exclusion set as on other tests using .set), so potentially reverting
Richard's change would still leave the alpha (and other affected)
testsuite(s) not failing on these tests anymore.

Jan

>>> Hans-Peter Nilsson <hp@bitrange.com> 17.11.05 10:49:37 >>>
On Thu, 17 Nov 2005, Alexandre Oliva wrote:
> On Nov 16, 2005, Richard Henderson <rth@redhat.com> wrote:
>
> > Alpha assembly obsconds with .set for other purposes.
> > As far as I know, = means the same thing everywhere.
>
> 'fraid not, I'd used it initially, and was asked to change it
because
> some ports didn't support it.

(raises hand)
Um, MMIX, where these tests used to PASS...

>  Maybe .equ or .equiv would give us more
> portability?

Looking at read.c, (only) the generic .equ is a synonym for the
generic .set, but tc-hppa.c and tc-tic4x.c redefines them
incompatibly.  Maybe a new pseudo?

If you must, please skip these tests for MMIX.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]