This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: New tests orphan2 and unknown2 fail in cris-elf
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: hjl at lucon dot org
- Cc: hans-peter dot nilsson at axis dot com, binutils at sourceware dot org
- Date: Mon, 19 Dec 2005 13:04:26 +0100
- Subject: Re: New tests orphan2 and unknown2 fail in cris-elf
> Received-SPF: none (bart: domain of hjl@lucon.org does not designate permitted sender hosts) client ip=68.142.198.200; envelope-from=hjl@lucon.org; helo=smtp101.sbc.mail.mud.yahoo.com;
> Date: Sun, 18 Dec 2005 22:00:40 -0800
> From: "H. J. Lu" <hjl@lucon.org>
> That is a real bug. It affects all ELF linkers. This regression was
> introduced by
> http://sourceware.org/ml/binutils/2005-11/msg00350.html
Sure, but the test-case is new. If you need to commit a
test-case before the bug is fixed, please xfail the test; remove
the xfail when the bug only when the bug is fixed. This is the
rule from GCC, and it is the most practical for all parts. I
did the obvious change.
> > unknown2 uses -shared without testing that the linker supports
> > it.
>
> That one is supposed to fail with -shared only. See
>
> http://sourceware.org/ml/binutils/2005-11/msg00343.html
>
> >
> > Maybe using "target: *-*-linux*" is the right fix for both of
> > them. Thanks.
>
> Feel free to add "target: *-*-linux*" for unknown2.
Done. However, it's expected that whoever effectively adds the
failing test-case fixes it. Thanks.
Committed obvious patch follows:
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ChangeLog,v
retrieving revision 1.583
diff -p -u -r1.583 ChangeLog
--- ChangeLog 18 Dec 2005 23:50:41 -0000 1.583
+++ ChangeLog 19 Dec 2005 11:58:34 -0000
@@ -1,3 +1,8 @@
+2005-12-19 Hans-Peter Nilsson <hp@axis.com>
+
+ * ld-elf/unknown2.d: Only run for *-*-linux*.
+ * ld-elf/orphan2.d: Xfail everywhere.
+
2005-12-18 H.J. Lu <hongjiu.lu@intel.com>
PR ld/2065
Index: ld-elf/orphan2.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/orphan2.d,v
retrieving revision 1.1
diff -p -u -r1.1 orphan2.d
--- ld-elf/orphan2.d 18 Dec 2005 23:50:41 -0000 1.1
+++ ld-elf/orphan2.d 19 Dec 2005 11:58:34 -0000
@@ -1,6 +1,7 @@
#source: orphan2.s
#ld: -r
#readelf: -S --wide
+#xfail: *-*-*
#...
\[[ 0-9]+\] \.text[ \t]+PROGBITS[ \t0-9a-f]+AX?.*
Index: ld-elf/unknown2.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/unknown2.d,v
retrieving revision 1.1
diff -p -u -r1.1 unknown2.d
--- ld-elf/unknown2.d 18 Dec 2005 16:21:49 -0000 1.1
+++ ld-elf/unknown2.d 19 Dec 2005 11:58:34 -0000
@@ -1,6 +1,7 @@
#source: unknown2.s
#ld: -shared
#readelf: -S
+#target: *-*-linux*
#...
\[[ 0-9]+\] \.note.foo[ \t]+NOTE[ \t]+.*
brgds, H-P