This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Adding hplt to elf_link_hash_table
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sourceware dot org, richard at codesourcery dot com
- Date: Sat, 25 Feb 2006 10:12:08 +1030
- Subject: Re: Adding hplt to elf_link_hash_table
- References: <87u0aoirt6.fsf@talisman.home>
On Fri, Feb 24, 2006 at 05:34:45PM +0000, Richard Sandiford wrote:
> I'm soon going to submit equivalent user-mode VxWorks support for ARM,
> and there are other targets to come, so would it be OK to have "hplt"
> in the common elf_link_hash_table, alongside "hgot"?
>
> This patch does that, and removes the now-redundant "hgot" field
> from elf_i386_link_hash_table. Tested individually on i586-vxworks
> and on i686-linux-gnu with --enable-targets=all --enable-64-bit-bfd.
> OK to install?
Yes, this is OK.
> BTW, I notice that elf32-ppc.c uses:
>
> if (strcmp (h->root.root.string, "_DYNAMIC") == 0
> || (!htab->is_vxworks
> && (h == htab->elf.hgot
> || strcmp (h->root.root.string,
> "_PROCEDURE_LINKAGE_TABLE_") == 0)))
> ...
>
> whereas most targets use string comparisons. Would you prefer
> all targets to use hash entry comparisons, and do it for both
> _GLOBAL_OFFSET_TABLE_ and _PROCEDURE_LINKAGE_TABLE_?
> If so, I'll submit a follow-up patch.
That would be nice too.
--
Alan Modra
IBM OzLabs - Linux Technology Centre