This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] New option --print-gc-sections
On Wed, Apr 05, 2006 at 09:51:19AM +0200, Eric Botcazou wrote:
> +static void
> +find_offset_in_section (bfd *abfd, asection *section)
> +{
> + bfd_size_type size;
> +
> + if (found)
> + return;
> +
> + if ((bfd_get_section_flags (abfd, section) & SEC_ALLOC) == 0)
> + return;
> +
> + size = bfd_get_section_size (section);
> + if (pc >= size)
> + return;
> +
> + found = bfd_find_nearest_line (abfd, section, syms, pc,
> + &filename, &functionname, &line);
> +}
It would be better to check that pc is not less than section vma, then
use "off = pc - vma" for size check and bfd_find_nearest_line. That way
--section lets you specify a section relative offset in an executable.
> @@ -276,12 +314,12 @@ process_file (const char *file_name, con
> bfd_close (abfd);
> }
>
> -int main (int, char **);
Don't delete this. I believe it is there to quash warnings generated by
some versions of gcc. OK with these changes.
--
Alan Modra
IBM OzLabs - Linux Technology Centre