This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
elf32-bfin.c: compile time warning
- From: Nick Clifton <nickc at redhat dot com>
- To: Bernd Schmidt <bernds_cb1 at t-online dot de>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 06 Apr 2006 10:44:38 +0100
- Subject: elf32-bfin.c: compile time warning
- References: <44342164.9000209@t-online.de>
Hi Bernd,
There is a minor problem with the bfin port - a compile time warning
for elf32-bfin.c when using a gcc 4.x based compiler:
.../bfd/elf32-bfin.c: In function 'bfinfdpic_relocs_info_hash':
.../bfd/elf32-bfin.c:1288: warning: signed and unsigned type in
conditional expression
It can be fixed by the attached patch. Any objections to my applying it ?
Cheers
Nick
bfd/ChangeLog
2006-04-06 Nick Clifton <nickc@redhat.com>
* elf32-bfin.c (bfinfdpic_relocs_info_hash): Add cast to remove
compile time warning message.
Index: bfd/elf32-bfin.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-bfin.c,v
retrieving revision 1.9
diff -c -3 -p -r1.9 elf32-bfin.c
*** bfd/elf32-bfin.c 5 Apr 2006 20:46:15 -0000 1.9
--- bfd/elf32-bfin.c 6 Apr 2006 09:45:11 -0000
*************** bfinfdpic_relocs_info_hash (const void *
*** 1285,1291 ****
return (entry->symndx == -1
? entry->d.h->root.root.hash
! : entry->symndx + entry->d.abfd->id * 257) + entry->addend;
}
/* Test whether the key fields of two bfinfdpic_relocs_info entries are
--- 1285,1291 ----
return (entry->symndx == -1
? entry->d.h->root.root.hash
! : (hashval_t) entry->symndx + entry->d.abfd->id * 257) + entry->addend;
}
/* Test whether the key fields of two bfinfdpic_relocs_info entries are