This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix buffer overflow in gas


On Tue, May 02, 2006 at 10:47:27AM +0100, Nick Clifton wrote:
> Hi H. J.
> 
> >There are some potential buffer overflows in gas. 8byte isn't enough
> >to hold a negative byte. This patch fixes them. Also we should use
> >snprintf instead of sprintf.
> 
> Did you test this patch ?  if so, please could you say how.

You can put some none ascii char in assembly code.

> 
> >2006-05-01  H.J. Lu  <hongjiu.lu@intel.com>
> >
> >	* config/tc-i386.c (output_invalid_buf): Change size to 16.
> >	* config/tc-tic30.c (output_invalid_buf): Likewise.
> >
> >	* config/tc-i386.c (output_invalid): Use snprintf instead of
> >	sprintf.
> >	* config/tc-ia64.c (declare_register_set): Likewise.
> >	(emit_one_bundle): Likewise.
> >	(check_dependencies): Likewise.
> >	* config/tc-tic30.c (output_invalid): Likewise.
> 
> Assuming that you have tested the targets involved and that there were 
> no regressions then this patch is approved.

Done.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]