This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: as bug
On Sun, May 07, 2006 at 03:48:25PM +0100, Nick Clifton wrote:
> Hi Alan,
>
> >+ /* Don't error on first few frag relax passes. */
> >+ if (pass < 2)
> >+ {
> >+ /* Force another pass. */
> >+ ret = 1;
> >+ break;
> >+ }
>
> I think that it might help if you include a comment saying *why* the
> first two passes should ignore a negative growth value.
As it happened, my commit failed due to gas/ChangeLog not being
up-to-date. Committing with this comment.
+ /* Don't error on first few frag relax passes.
+ The symbol might be an expression involving
+ symbol values from other sections. If those
+ sections have not yet been processed their
+ frags will all have zero addresses, so we
+ will calculate incorrect values for them. The
+ number of passes we allow before giving an
+ error is somewhat arbitrary. It should be at
+ least one, with larger values requiring
+ increasingly contrived dependencies between
+ frags to trigger a false error. */
--
Alan Modra
IBM OzLabs - Linux Technology Centre