This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Increment


Alan Modra <amodra@bigpond.net.au> writes:

> On Fri, May 26, 2006 at 02:46:47PM -0700, Ian Lance Taylor wrote:
>> bfd_hash_lookup in bfd/hash.c has an incorrectly indented and
>> misplaced increment of table->count:
>
> This seems to have fallen through the cracks.  Applying the obvious
> fix.
>
> 	* hash.c (bfd_hash_lookup): Correct stray line.

The linker is now crashing very often with an assertion failure in
_bfd_elf_strtab_delref.  Apparently the hash resizing was never properly
tested, since with the misplaced increment it was unlikely to ever
trigger.  In fact, disabling it will fix the crashes.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]