This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/2884: Crash in elf64_ia64_relocate_section
- From: James E Wilson <wilson at specifix dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 10 Jul 2006 13:10:59 -0700
- Subject: Re: PATCH: PR ld/2884: Crash in elf64_ia64_relocate_section
- References: <20060706232756.GA20456@lucon.org>
On Thu, 2006-07-06 at 16:27, H. J. Lu wrote:
> * elflink.c (_bfd_elf_merge_symbol): Set ref_dynamic to 0 for
> hidden and internal visibility. Copy the symbol info from the
> old versioned dynamic definition to the new one with
> non-default visibility.
This is an area I don't understand well, but this does look reasonable
to me.
> + /* Handle the case where the old dynamic definition is
> + versioned. We need to copy the symbol info from the
> + versioned symbol to the normal one if it is referenced
> + before. */
The only thing I noticed is that the second sentence here does not look
right to me. I think that should be "if it was referenced before".
--
Jim Wilson, GNU Tools Support, http://www.specifix.com