This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] MIPS gas: Simplify MIPS16 jump relocation handling

From: Eric Christopher <echristo at apple dot com>
To: Martin Michlmayr <tbm at cyrius dot com>
Cc: Thiemo Seufer <ths at networkno dot de>, binutils at sourceware dot org
Date: Mon, 31 Jul 2006 11:00:50 -0700
Subject: Re: [PATCH] MIPS gas: Simplify MIPS16 jump relocation handling
References: <20060731172544.GL15011@networkno.de> <20060731174345.GC17974@deprecation.cyrius.com>

Martin Michlmayr wrote:

* Thiemo Seufer <ths@networkno.de> [2006-07-31 18:25]:

-      /* Nothing needed to do. The value comes from the reloc entry */
+      /* Nothing needed to do. The value comes from the reloc entry */


I think this comment doesn't comform to the coding style (i.e. it's
missing a dot and a space at the end).

Actually, . and two spaces. The standard is for two spaces after a period.

-eric

References:
- [PATCH] MIPS gas: Simplify MIPS16 jump relocation handling
  - From: Thiemo Seufer
- Re: [PATCH] MIPS gas: Simplify MIPS16 jump relocation handling
  - From: Martin Michlmayr

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]