This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Robustify use-thumb-lib


Hello,
as discovered by a coworker, the use-thumb-lib tests is still not robust 
enough -- it will break if bucket numbers change, which is quite possible.

The attached patch makes the test check just for the 'important' line, the 
test still passes on mainline.

(I don't have write access)

Thanks,
Volodya

2006-09-19  Vladimir Prus  <vladimir@codesourcery.com>

        * ld-arm/use-thumb-lib.sym: Robustify, by ignoring symbols we're not
        interested in and bucket number.
Index: use-thumb-lib.sym
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/use-thumb-lib.sym,v
retrieving revision 1.2
diff -u -p -r1.2 use-thumb-lib.sym
--- use-thumb-lib.sym	20 Jun 2006 13:55:08 -0000	1.2
+++ use-thumb-lib.sym	19 Sep 2006 17:05:56 -0000
@@ -1,15 +1,3 @@
-
-Symbol table for image:
-  Num Buc:    Value  Size   Type   Bind Vis      Ndx Name
-   11   0: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS _edata
-   10   0: 00000268    20    FUNC GLOBAL DEFAULT   6 foo
-    4   0: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS __bss_start__
-   12   1: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS _end
-    7   1: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS __bss_end__
-    5   1: 0000027c     0  NOTYPE GLOBAL DEFAULT ABS __exidx_start
-   13   2: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS __data_start
-    9   2: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS __end__
-    8   2: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS __bss_start
-    6   2: 00000000     2    FUNC GLOBAL DEFAULT UND lib_func2
-    3   2: 0000830c     0  NOTYPE GLOBAL DEFAULT ABS _bss_end__
-    2   2: 0000027c     0  NOTYPE GLOBAL DEFAULT ABS __exidx_end
+#...
+   ..  ..: 00000000     2    FUNC GLOBAL DEFAULT UND lib_func2
+#pass

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]