This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Make the compiler do the math 2.
Nick Clifton <nickc@redhat.com> writes:
> Hi Pedro,
>
>> bfd/ChangeLog
>> 2006-09-12 Pedro Alves <pedro_alves@portugalmail.pt>
>>
>> * elf.c (_bfd_elf_make_section_from_shdr): New macro DSECT.
>> (_bfd_elf_make_section_from_shdr, debug_sections): Use DSECT.
>
> Thanks for working on this.
>
> I have taken your patch, renamed the macro to STRING_COMMA_LEN, and added
> a second macro CONST_STRNEQ, but them in bfd.h and then used them
> everywhere in the bfd code where I could apply them. I have tested as
> thoroughly as I can, and I think that there are no regressions although of
> course I will fix anything that does turn up.
You can't use STRING_COMMA_LEN as part of a function call because it may
be a macro:
../../bfd/elflink.c:10069:47: error: macro "memcpy" requires 3 arguments, but only 2 given
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."