This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: PR binutils/3262: objcopy --only-keep-debug produces extra large debuginfo.
- From: "H. J. Lu" <hjl at lucon dot org>
- To: binutils at sources dot redhat dot com
- Date: Tue, 26 Sep 2006 12:06:11 -0700
- Subject: PATCH: PR binutils/3262: objcopy --only-keep-debug produces extra large debuginfo.
We have uninitialized fields in segment map. In this particular case,
p_align_valid is 1 and p_align is a large number. I am checking in
this patch as an abvious fix.
H.J.
---
2006-09-26 H.J. Lu <hongjiu.lu@intel.com>
PR binutils/3262
* elf.c (rewrite_elf_program_header): Use bfd_zalloc instead of
bfd_alloc to allocate segment map.
(copy_elf_program_header): Likewise.
--- bfd/elf.c.zero 2006-09-24 10:26:59.000000000 -0700
+++ bfd/elf.c 2006-09-26 12:02:35.000000000 -0700
@@ -5401,7 +5401,7 @@ rewrite_elf_program_header (bfd *ibfd, b
all of the sections we have selected. */
amt = sizeof (struct elf_segment_map);
amt += ((bfd_size_type) section_count - 1) * sizeof (asection *);
- map = bfd_alloc (obfd, amt);
+ map = bfd_zalloc (obfd, amt);
if (map == NULL)
return FALSE;
@@ -5796,7 +5796,7 @@ copy_elf_program_header (bfd *ibfd, bfd
amt = sizeof (struct elf_segment_map);
if (section_count != 0)
amt += ((bfd_size_type) section_count - 1) * sizeof (asection *);
- map = bfd_alloc (obfd, amt);
+ map = bfd_zalloc (obfd, amt);
if (map == NULL)
return FALSE;