This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: trivial tidyup in bfd/reloc.c

From: Ben Elliston <bje at au1 dot ibm dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: binutils at sourceware dot org
Date: Thu, 26 Oct 2006 11:25:02 +1000
Subject: Re: PATCH: trivial tidyup in bfd/reloc.c
References: <20061026002216.GA23145@ozlabs.au.ibm.com> <m3odrzgbmv.fsf@localhost.localdomain>

> I just want to note that I don't think we should start a general
> trend of removing cases that are the same as the default case.  I
> think they provide a useful comment, to wit: I have considered this
> case explicitly, and this is how it should be handled.

Sure--understood.  Although, I think that a comment accompanying such
cases wouldn't go astray.

> In this particular case, though, I see no benefit to the "case 0",
> and I think your patch is fine.

Thanks.

Ben

References:
- PATCH: trivial tidyup in bfd/reloc.c
  - From: Ben Elliston
- Re: PATCH: trivial tidyup in bfd/reloc.c
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]