This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] better error output from ar when given a directory
- From: Daniel Jacobowitz <drow at false dot org>
- To: Mike Frysinger <vapier at gentoo dot org>, binutils at sourceware dot org, dwhedon at gordian dot com, james at nocrew dot org, doko at debian dot org
- Date: Fri, 27 Oct 2006 11:00:34 -0400
- Subject: Re: [patch] better error output from ar when given a directory
- References: <200610212010.41536.vapier@gentoo.org> <20061027145706.GE27654@bubble.grove.modra.org>
On Sat, Oct 28, 2006 at 12:27:06AM +0930, Alan Modra wrote:
> @@ -300,6 +303,7 @@ const char *const bfd_errmsgs[] =
> N_("Bad value"),
> N_("File truncated"),
> N_("File too big"),
> + N_("Error reading "),
> N_("#<Invalid error code>")
> };
>
That's practically a contradiction: N_ means to translate the string,
but you're assuming the translation will have the filename at the end.
I think you probably want to put something bogus there, like a copy of
the following error, and use a separate format string...
> + if (error_tag == bfd_error_on_input)
> + return concat (_(bfd_errmsgs [error_tag]), input_bfd->filename, ": ",
> + bfd_errmsg (input_error), NULL);
> +
here.
--
Daniel Jacobowitz
CodeSourcery