This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Xtensa] fix broken sanity check in GAS


I've committed this patch to fix a broken check for malformed loops in the Xtensa port of GAS. Tested and committed on the mainline.

2006-11-27 Sterling Augustine <sterling@tensilica.com>

	* config/tc-xtensa.c (xtensa_sanity_check): Check for RELAX_IMMED
	as the first slot_subtype, not the frag subtype.

Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.71
diff -u -p -r1.71 tc-xtensa.c
--- config/tc-xtensa.c	27 Nov 2006 20:14:52 -0000	1.71
+++ config/tc-xtensa.c	27 Nov 2006 23:54:03 -0000
@@ -7675,9 +7675,9 @@ xtensa_sanity_check (void)
 	/* Walk over all of the fragments in a subsection.  */
 	for (fragP = frchP->frch_root; fragP; fragP = fragP->fr_next)
 	  {
-	    /* Currently we only check for empty loops here.  */
 	    if (fragP->fr_type == rs_machine_dependent
-		&& fragP->fr_subtype == RELAX_IMMED)
+		&& fragP->fr_subtype == RELAX_SLOTS 
+		&& fragP->tc_frag_data.slot_subtypes[0] == RELAX_IMMED)
 	      {
 		static xtensa_insnbuf insnbuf = NULL;
 		TInsn t_insn;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]