This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Remove output file first when run test
- From: Andreas Schwab <schwab at suse dot de>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 23 Jan 2007 14:31:17 +0100
- Subject: Re: PATCH: Remove output file first when run test
- References: <20070118013820.GA5019@lucon.org>
"H. J. Lu" <hjl@lucon.org> writes:
> @@ -879,6 +882,7 @@ proc run_dump_test { name } {
> }
> } else {
> set objfile "tmpdir/dump0.o"
> + catch "exec rm -f $objfile" exec_output
This is wrong. It removes the assembler output which is the input to the
rest of the tests, causing ld-powerpc/plt1 to fail.
Checked in as obvious.
Andreas.
2007-01-23 Andreas Schwab <schwab@suse.de>
* lib/ld-lib.exp (run_dump_test): Don't prematurely remove
assembler output.
--- ld/testsuite/lib/ld-lib.exp.~1.45.~ 2007-01-19 12:03:31.000000000 +0100
+++ ld/testsuite/lib/ld-lib.exp 2007-01-23 14:04:14.000000000 +0100
@@ -1,6 +1,6 @@
# Support routines for LD testsuite.
# Copyright 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003,
-# 2004, 2005, 2006 Free Software Foundation, Inc.
+# 2004, 2005, 2006, 2007 Free Software Foundation, Inc.
#
# This file is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -882,7 +882,6 @@ proc run_dump_test { name } {
}
} else {
set objfile "tmpdir/dump0.o"
- catch "exec rm -f $objfile" exec_output
}
# We must not have expected failure if we get here.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."