This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix linking of .gpdword on MIPS
- From: Daniel Jacobowitz <drow at false dot org>
- To: binutils at sourceware dot org, rsandifo at nildram dot co dot uk
- Date: Mon, 26 Feb 2007 20:40:36 -0500
- Subject: Re: Fix linking of .gpdword on MIPS
- References: <877iu4k03j.fsf@firetop.home>
On Mon, Feb 26, 2007 at 10:47:28PM +0000, Richard Sandiford wrote:
> But that isn't true on MIPS; r_symndx is also zero the second
> and subsequent entries in a composite relocation, when the addend
> is carried over from the result of the previous relocations.
Sorry.
> Are we really confident that this is the only exception, and that true
> relocations against symbol zero will not reach here? If so, I think
> the patch below is the correct fix. If not, it seems dangerous to
> explicitly ignore what I understand to be correct semantics,
> and treat S + A as zero simply because S is zero.
It's the right thing to do if the comment accurately described the
check. I was as thorough as I could be checking my assumptions, but
obviously not thorough enough. Does HJ's patch help?
--
Daniel Jacobowitz
CodeSourcery