This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: The current assembler is broken


On Mar 14, 2007, "H. J. Lu" <hjl@lucon.org> wrote:

> See
> http://sources.redhat.com/bugzilla/show_bug.cgi?id=4184

Thanks for the report and testcase.  This patch fixes it.  I could
reintroduce a state to output the blank, but...  No point in doing it
if we don't need it, right?

Ok to install?

for  gas/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* app.c (do_scrub_chars): PUT after setting states.

Index: trunk/gas/app.c
===================================================================
--- trunk.orig/gas/app.c	2007-03-09 20:25:22.000000000 -0300
+++ trunk/gas/app.c	2007-03-15 02:14:23.000000000 -0300
@@ -510,11 +510,10 @@ do_scrub_chars (int (*get) (char *, int)
 		ch = GET ();
 	      if (ch == '"')
 		{
-		  PUT (' ');
-		  PUT (ch);
 		  quotechar = ch;
 		  state = 5;
 		  old_state = 3;
+		  PUT (ch);
 		}
 	      else
 		{
-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]