Re: [PATCH] Solaris x86-64 fixes for binutils

[Michael Wetherell <mike dot wetherell at ntlworld dot com>]

On Monday 19 Mar 2007 20:46, Alex Bennee wrote:
> > You're repeating work that was already done a few months ago. As I
> > already said it should already work if you just try the latest.
>
> I have got the latest cvs although having to rebuild gcc with the new
> binutils each time is currently slowing my testing.

I did say, so it wouldn't have hurt to check ;-)

> However looking at the CVS code I couldn't find:
>
> * The correct .interp setting for the linker

It's in ld/emulparams/elf_x86_64.sh

> * The additional sections

That's because the sections are OS specific and can't be added to the 
generic switch like that.

The way it was intended to work was that e_ident[EI_OSABI] would be set 
whenever OS specific extensions are used, indicating which OS they are 
for: http://www.cygwin.com/ml/binutils/2000-11/msg00383.html
So then it would have been possible to switch on  e_ident[EI_OSABI] 
first. But since neither GNU nor Solaris set it like that, it doesn't 
help.

In any case unrecognised OS specific sections shouldn't cause an error 
unless SHF_OS_NONCONFORMING is in the flag bits. So I just fixed that, 
which I hope is sufficient.

> Have you tested on 64 bit binaries? 

Yes native and cross.

> I'll be quite happy if none of the patches are needed :-)

And I'll be happy if you've got more fixes.

Regards,
Mike