This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
- From: Andreas Schwab <schwab at suse dot de>
- To: binutils at sources dot redhat dot com
- Cc: "H. J. Lu" <hjl at lucon dot org>
- Date: Wed, 21 Mar 2007 11:28:12 +0100
- Subject: Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
- References: <20070314221041.GA22363@lucon.org> <je7italx0x.fsf@sykes.suse.de>
Andreas Schwab <schwab@suse.de> writes:
> "H. J. Lu" <hjl@lucon.org> writes:
>
>> --- binutils/gas/config/tc-i386.h.opc 2007-03-12 14:36:55.000000000 -0700
>> +++ binutils/gas/config/tc-i386.h 2007-03-14 14:21:57.000000000 -0700
>> @@ -96,10 +96,6 @@ extern const char extra_symbol_chars[];
>> extern const char *i386_comment_chars;
>> #define tc_comment_chars i386_comment_chars
>>
>> -#define MAX_OPERANDS 4 /* max operands per insn */
>> -#define MAX_IMMEDIATE_OPERANDS 2/* max immediates per insn (lcall, ljmp, insertq, extrq) */
>> -#define MAX_MEMORY_OPERANDS 2 /* max memory refs per insn (string ops) */
>> -
>> /* Prefixes will be emitted in the order defined below.
>> WAIT_PREFIX must be the first prefix since FWAIT is really is an
>> instruction, and so must come before any prefixes.
>> @@ -118,21 +114,6 @@ extern const char *i386_comment_chars;
>> #define IMMEDIATE_PREFIX '$'
>> #define ABSOLUTE_PREFIX '*'
>>
>> -#define TWO_BYTE_OPCODE_ESCAPE 0x0f
>> -#define NOP_OPCODE (char) 0x90
>
> Which means that frag_align_code no longer nop-fills.
Installed as obvious.
Andreas.
2007-03-21 Andreas Schwab <schwab@suse.de>
* config/tc-i386.h (NOP_OPCODE): Restore.
--- gas/config/tc-i386.h.~1.85.~ 2007-03-16 11:07:03.000000000 +0100
+++ gas/config/tc-i386.h 2007-03-21 11:23:57.000000000 +0100
@@ -114,6 +114,9 @@ extern const char *i386_comment_chars;
#define IMMEDIATE_PREFIX '$'
#define ABSOLUTE_PREFIX '*'
+/* Byte to use for filling in frag_align_code. */
+#define NOP_OPCODE (char) 0x90
+
/* these are the instruction mnemonic suffixes. */
#define WORD_MNEM_SUFFIX 'w'
#define BYTE_MNEM_SUFFIX 'b'
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."