This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Move i386 opcode to opcodes/i386-opc.c

From: "H. J. Lu" <hjl at lucon dot org>
To: Andreas Schwab <schwab at suse dot de>
Cc: binutils at sources dot redhat dot com
Date: Wed, 21 Mar 2007 07:16:28 -0700
Subject: Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
References: <20070314221041.GA22363@lucon.org> <je7italx0x.fsf@sykes.suse.de> <je3b3ylwlf.fsf@sykes.suse.de> <20070321135659.GA19548@lucon.org> <jed532k858.fsf@sykes.suse.de>

On Wed, Mar 21, 2007 at 03:01:39PM +0100, Andreas Schwab wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
> 
> > NOP_OPCODE is defined in opcode/i386.h.
> 
> But it still lacks a comment.
> 

The opcode of nop instruction for x86 is 0x90. NOP_OPCODE shouldn't
be defined to something else.


H.J.

Follow-Ups:
- Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
  - From: Andreas Schwab

References:
- PATCH: Move i386 opcode to opcodes/i386-opc.c
  - From: H. J. Lu
- Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
  - From: Andreas Schwab
- Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
  - From: Andreas Schwab
- Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
  - From: H. J. Lu
- Re: PATCH: Move i386 opcode to opcodes/i386-opc.c
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]