This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: windres
On Tue, Apr 17, 2007 at 09:32:30AM +0200, Kai Tietz wrote:
>"H. J. Lu" <hjl@lucon.org> wrote on 16.04.2007 23:58:49:
>>On Mon, Apr 16, 2007 at 05:07:10PM -0400, Christopher Faylor wrote:
>>>If you are assuming that int means 32 bits, wouldn't it make sense to
>>>use a type like u_int32_t which explicitly spells that out?
>>
>>u_int32_t is a good idea if it doesn't require extra change since this
>>is a temporary patch until windres can be rewritten properly.
>
>Such a types as u_int32_t, u_int16_t, ... are really a good idea, but
>that these types are not available on all platforms in sys/types.h. :(
>So this would need some further work on a temporary thing. But I
>think, it would be a good idea to introduce those kind of types to bfd.
>E.g. bfd_uint32_t, bfd_int32, bfd_int16, ...
We've all had experience with "temporary" changes, though, so I think it
makes sense to do this the right way. Doesn't configure provide a way to
determine the size of ints/longs?
cgf