Re: [PATCH] add --reverse option to objcopy

[Nick Clifton <nickc at redhat dot com>]

Hi Nathan,

> OK?

Yes, but there are a couple of niggles:

  * H.J. pointed out that the name of the switch is slightly confusing.
    --reverse-endian or --reverse-bytes might be a more reasonable name.

  * I think that this paragraph in the documentation is rather
    confusing:

+By using @samp{--reverse=2} followed by @samp{--reverse=4}, then bytes
+ordered @code{34127856} would be generated.

    To me this implied that you can use the --reverse switch twice on 
the same command line in order to achieve the effect you describe.  If I 
have read the code correctly however, only the last instance of the 
switch on the command line will be honored, and so you need to run the 
objcopy command *twice* in order to achieve the desired effect.

    This leads on to the third point which is:

  * The code should check to see if --reverse if issued more than once 
on the command line and (if they have different values) warn the user 
that the earlier value(s) are being ignored.

Cheers
  Nick