This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: patch: Updated II windres tool Part 1 of 2
- From: Nick Clifton <nickc at redhat dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: Dave Korn <dave dot korn at artimi dot com>, "'Binutils'" <binutils at sourceware dot org>, "'Danny Smith'" <dannysmith at clear dot net dot nz>
- Date: Tue, 22 May 2007 17:39:33 +0100
- Subject: Re: patch: Updated II windres tool Part 1 of 2
- References: <OF0DCE9979.2782E449-ONC12572E3.00572AE8-C12572E3.0057BD78@onevision.de>
Hi Kai,
here the adjusted code. The lack of some bytes in res seems to be reasoned
by bfd not treating the section content length before something was
written there ?
The type bfd_vma is replaced by rc_uint_type. The testcase can be taken
from my last patch.
Hmm, I still see one binutils testsuite failure:
< 0070 5300a200 ffff0000 63006c00 61007300 S.......c.l.a.s.
> 0070 5300a200 ffffffff 43004c00 41005300 S.......C.L.A.S.
FAIL: windres/dialogid (compare)
The "classname" strings in the dialogid.rc file have been converted into
uppercase. This looks correct to me. (ie I think that the testcase is
wrong in expecting the resource name to remain in lower case). Do you
agree ? If so I will fix up the testcase.
Cheers
Nick