This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: windres allows string concat


Hi Kai,

This patch allows that "rc"-parser joins strings for style's CAPTION, CLASS, FONT (names), and for menu elements MENUITEM & POPUP, and also for version VALUE text elements.

Did you test this patch ? If so, how ?
[As a general point you should always test patches and always report how you tested them. Eg in this case by rerunning the binutils testsuite for windres using toolchain and showing that there are no regressions].


Also, since you are adding a new feature, it would be a good idea if you could add a new testcase to check it.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]