This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch]: PR 577 & "#pragma code_page" support for windres
- From: Nick Clifton <nickc at redhat dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: Dave Korn <dave dot korn at artimi dot com>, "'Binutils'" <binutils at sourceware dot org>
- Date: Mon, 18 Jun 2007 16:30:44 +0100
- Subject: Re: [patch]: PR 577 & "#pragma code_page" support for windres
- References: <OFD1D2A8D8.7D8A35FE-ONC12572FE.003239AB-C12572FE.0033060C@onevision.de>
Hi Kai,
I have checked your patch in.
I made a few minor changes:
* I added comments to the pragma parsing code in cpp_line()
indicating that we ought to be generating warning and error
messages when we encounter unknown or badly formed pragmas.
* I added an entry to the binutils/NEWS file mentioning the new
feature available in windres. This entry probably should be
expanded to include your other recent changes.
* The ChangeLog entry prefixed each of the filenames with
"binutils/", but this is unnecessary since the ChangeLog file
itself is in the binutils/ directory.
Cheers
Nick
PS. A test case for the new pragma parsing code would be a good idea...