This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Remove code duplication in dwarf2.c


Hi H.J.

Both _bfd_dwarf2_find_nearest_line and _bfd_dwarf2_find_line have
the same code to follow .gnu_debuglink section.  This patch uses
a function instead of duplicating the code. OK to install?

Sort-of. Andreas has just posted a patch to provide a global debug directory parameter to the call to bfd_follow_gnu_debuglink() which I would like to see integrated into your patch. Plus it seems to me that there is a lot more code duplication between _bfd_dwarf2_find_line and _bfd_dwarf2_find_nearest_line, so maybe you could expand your patch even more ?


Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]