This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR binutils/4667: Incorrect mode for x86 SIMD insns


I got confirmation that PR binutils/4667 was fixed with this patch.
I will check it in. If Intel mode regressions are found, we will
add the new tests into gas testsuite and fix them.


H.J.
On Fri, Jun 22, 2007 at 09:33:53PM -0700, H. J. Lu wrote:
> In Intel mode, we print wrong modes for many SSE/MMX insns.  The
> problem is v_mode is passed to OP_EX, which uses prefix to decide
> actual mode. It is highly inaccurate.  OP_EM has similar issue. But
> v_mode works most of time. punpckXXX are only a few exceptions.
> This patch passes the right mode to OP_EX and adds EMd/EMq for
> punpckXXX.
> 
> 
> H.J.
> ----
> gas/testsuite/
> 
> 2007-06-22  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR binutils/4667
> 	* gas/i386/i386.exp: Run simd, simd-intel, x86-64-simd
> 	and x86-64-simd-intel.
> 
> 	* gas/i386/opcode-intel.d: Updated.
> 
> 	* gas/i386/simd-intel.d: New.
> 	* gas/i386/simd.d: Likewise.
> 	* gas/i386/simd.s: Likewise.
> 	* gas/i386/x86-64-simd-intel.d: Likewise.
> 	* gas/i386/x86-64-simd.d: Likewise.
> 	* gas/i386/x86-64-simd.s: Likewise.
> 
> opcodes/
> 
> 2007-06-22  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR binutils/4667
> 	* i386-dis.c (EX): Removed.
> 	(EMd): New.
> 	(EMq): Likewise.
> 	(EXd): Likewise.
> 	(EXq): Likewise.
> 	(EXx): Likewise.
> 	(PREGRP93...PREGRP97): Likewise.
> 	(dis386_twobyte): Updated.
> 	(prefix_user_table): Updated. Add PREGRP93...PREGRP97.
> 	(OP_EX): Remove Intel syntax handling.
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]