This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR ld/4701: binutils generates invalid klibc-based binary on Linux x86_64


On Wed, Jun 27, 2007 at 11:44:10AM -0700, H. J. Lu wrote:
> On Wed, Jun 27, 2007 at 11:09:03AM -0700, H. J. Lu wrote:
> > I don't think we can skip segment alignment on disk when its offset
> > < alignment. This patch fixes it. I will try to find a small testcase.

Why ever does file offset matter for a segment that isn't loaded from
disk??

> 	PR ld/4701
> 	* elf.c (assign_file_positions_for_load_sections): Skip segment
> 	alignment on disk only if its offset >= alignment.

And if it does matter, this patch can't be correct.  The old code used
to always align.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]