This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[patch] bfd: plug memory leak
- From: msnyder at sonic dot net
- To: binutils at sourceware dot org
- Date: Thu, 28 Jun 2007 15:40:52 -0700 (PDT)
- Subject: [patch] bfd: plug memory leak
Flagged by Coverity.
Forgive the whitespace globbing.
2007-06-28 Michael Snyder <msnyder@svkmacdonelllnx>
* bfd.c (bfd_demangle): Plug memory leak (Coverity).
Index: bfd.c
===================================================================
RCS file: /cvs/src/src/bfd/bfd.c,v
retrieving revision 1.94
diff -p -r1.94 bfd.c
*** bfd.c 27 Jun 2007 11:54:09 -0000 1.94
--- bfd.c 28 Jun 2007 21:10:30 -0000
*************** bfd_demangle (bfd *abfd, const char *nam
*** 1774,1780 ****
suf_len = strlen (suf) + 1;
final = bfd_malloc (pre_len + len + suf_len);
if (final == NULL)
! return NULL;
memcpy (final, pre, pre_len);
memcpy (final + pre_len, res, len);
--- 1774,1784 ----
suf_len = strlen (suf) + 1;
final = bfd_malloc (pre_len + len + suf_len);
if (final == NULL)
! {
! /* Free res before returning! */
! free (res);
! return NULL;
! }