This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Your recent ELF-related changes cause cris-axis-elf ld regressions when assembling for a.out
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 29 Jun 2007 20:05:09 +0000 (UTC)
- Subject: Re: Your recent ELF-related changes cause cris-axis-elf ld regressions when assembling for a.out
- References: <200706291735.l5THZxjX006442@ignucius.se.axis.com>
On Fri, 29 Jun 2007, Hans-Peter Nilsson wrote:
> FAIL: ld-cris/def2
> FAIL: ld-cris/undef2
> FAIL: ld-cris/warn1
> FAIL: ld-cris/warn3
I've applied this patch as obvious to fix this. Tested with crosses to
cris-axis-elf and arm-none-eabi.
2007-06-29 Joseph Myers <joseph@codesourcery.com>
* as.c (main): Only call create_obj_attrs_section if IS_ELF.
Index: as.c
===================================================================
RCS file: /cvs/src/src/gas/as.c,v
retrieving revision 1.73
diff -u -r1.73 as.c
--- as.c 29 Jun 2007 16:29:16 -0000 1.73
+++ as.c 29 Jun 2007 20:01:03 -0000
@@ -1174,7 +1174,8 @@
#endif
#ifdef OBJ_ELF
- create_obj_attrs_section ();
+ if (IS_ELF)
+ create_obj_attrs_section ();
#endif
#if defined OBJ_ELF || defined OBJ_MAYBE_ELF
--
Joseph S. Myers
joseph@codesourcery.com