This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] coff-i386, guard against null

From: Daniel Jacobowitz <drow at false dot org>
To: "H.J. Lu" <hjl at lucon dot org>
Cc: msnyder at sonic dot net, binutils at sourceware dot org
Date: Thu, 26 Jul 2007 07:41:39 -0400
Subject: Re: [patch] coff-i386, guard against null
References: <22002.12.7.175.2.1185409273.squirrel@webmail.sonic.net> <20070726021855.GA29523@lucon.org>

On Wed, Jul 25, 2007 at 07:18:55PM -0700, H.J. Lu wrote:
> On Wed, Jul 25, 2007 at 05:21:13PM -0700, msnyder@sonic.net wrote:
> > Other code in this function checks to see if sym is null.
> > If it's null here, it'll fail.
> > 
> 
> > 2007-07-25  Michael Snyder  <msnyder@access-company.com>
> > 
> > 	* coff-i386.c (coff_i386_rtype_to_howto): Guard against null.
> > 
> 
> I prefer BFD_ASSERT (sym != NULL).

BFD_ASSERT returns, though.

-- 
Daniel Jacobowitz
CodeSourcery

Follow-Ups:
- Re: [patch] coff-i386, guard against null
  - From: H.J. Lu

References:
- [patch] coff-i386, guard against null
  - From: msnyder
- Re: [patch] coff-i386, guard against null
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]