This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] aout relocs


> Hi Michael,
>
>>> That's the only place where something needs to be done (the pointer
>>> must
>>> still be valid even if the size is zero).
>>
>> Alright -- that's enough to justify the patch, isn't it?
>
> Certainly - please apply it.  Although you could simplify the second part
> of
> the patch by just checking to see if count is zero and returning, in the
> same
> way as you check reloc_size.

Done.

> That way you do not need to check the return values of both allocs.

Well, yes I do -- bfd_malloc can still fail.
Checked in as attached.

Attachment: slurp_reloc.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]