This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/4909: request for more helpful "can't allocate in segment" error message
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H.J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 10 Aug 2007 07:41:37 +0930
- Subject: Re: PATCH: PR ld/4909: request for more helpful "can't allocate in segment" error message
- References: <20070809191119.GA29149@lucon.org>
On Thu, Aug 09, 2007 at 12:11:19PM -0700, H.J. Lu wrote:
> PR ld/4909
> * elf.c (print_segment_map): New function.
> (assign_file_positions_for_load_sections): Call print_segment_map
> when a section can't be allocated in segment.
OK. A few minor nits.
> +print_segment_map (struct elf_segment_map *m)
Make m const.
> + fprintf (stderr, "%s: ", pt);
Don't print the space here.
> + for (j = 0; j < m->count; j++)
> + fprintf (stderr, "%s ", m->sections [j]->name);
Preceed %s with a space here instead.
--
Alan Modra
Australia Development Lab, IBM