This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR binutils/5233: objcopy won't change section flags on zero file-size sections
- From: Andrew STUBBS <andrew dot stubbs at st dot com>
- To: "H.J. Lu" <hjl at lucon dot org>
- Cc: binutils at sourceware dot org, nathan at codesourcery dot com
- Date: Thu, 01 Nov 2007 14:14:43 +0000
- Subject: Re: PATCH: PR binutils/5233: objcopy won't change section flags on zero file-size sections
- References: <47263757.2070908@st.com> <20071029201632.GA20411@lucon.org> <4727442B.20805@st.com> <20071030185550.GA26326@lucon.org> <20071030214239.GA27021@lucon.org>
H.J. Lu wrote:
Here is the patch for testcase. This change:
--- elf.c.flags 2007-10-30 10:51:02.000000000 -0700
+++ elf.c 2007-10-30 14:10:46.000000000 -0700
@@ -5557,12 +5557,14 @@ rewrite_elf_program_header (bfd *ibfd, b
*pointer_to_map = map;
pointer_to_map = &map->next;
+#if 0
if (matching_lma != map->p_paddr
&& !map->includes_filehdr && !map->includes_phdrs)
/* There is some padding before the first section in the
segment. So, we must account for that in the output
segment's vma. */
map->p_vaddr_offset = matching_lma - map->p_paddr;
+#endif
free (sections);
continue;
will fix this regression.
Are there any unpleasant side-effects from removing this code?
Andrew