This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
segment wrap around bug
- From: Nathan Sidwell <nathan at codesourcery dot com>
- To: binutils <binutils at sources dot redhat dot com>
- Date: Wed, 28 Nov 2007 13:20:07 +0000
- Subject: segment wrap around bug
this patch fixes a SECTION_IN_SEGMENT check that was failing for a segment right
at the end of memory. I've rearranged the maths to avoid integer wrapping.
tested on powerpc-wrs-vxworks
ok?
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
2007-11-28 Nathan Sidwell <nathan@codesourcery.com>
Issue #2297
include/elf/
* internal.h (ELF_IS_SECTION_IN_SEGMENT): Adjust to cope with
segments at the end of memory.
Index: include/elf/internal.h
===================================================================
--- include/elf/internal.h (revision 187336)
+++ include/elf/internal.h (working copy)
@@ -280,11 +280,12 @@ struct elf_segment_map
|| ((bfd_vma) sec_hdr->sh_offset >= segment->p_offset \
&& (sec_hdr->sh_offset + ELF_SECTION_SIZE(sec_hdr, segment) \
<= segment->p_offset + segment->p_filesz))) \
- /* SHF_ALLOC sections must have VMAs within the segment. */ \
+ /* SHF_ALLOC sections must have VMAs within the segment. Be \
+ careful about segments right at the end of memory. */ \
&& ((sec_hdr->sh_flags & SHF_ALLOC) == 0 \
|| (sec_hdr->sh_addr >= segment->p_vaddr \
- && (sec_hdr->sh_addr + ELF_SECTION_SIZE(sec_hdr, segment) \
- <= segment->p_vaddr + segment->p_memsz))))
+ && (sec_hdr->sh_addr - segment->p_vaddr \
+ + ELF_SECTION_SIZE(sec_hdr, segment) <= segment->p_memsz))))
/* Decide if the given sec_hdr is in the given segment in file. */
#define ELF_IS_SECTION_IN_SEGMENT_FILE(sec_hdr, segment) \